style: инициализировать слайсы через make

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
2026-08-09 00:32:47 +03:00
parent 3950dd94ee
commit 174b5f9048
7 changed files with 69 additions and 67 deletions
+31 -21
View File
@@ -18,6 +18,16 @@ import (
"git.tswf.io/infra/go-synapse-backupper/pkg/domain/crypto"
)
func makeRecipientPubs(pqPub, classicalPub crypto.RecipientPub) []crypto.RecipientPub {
pubs := make([]crypto.RecipientPub, 0, 2)
return append(pubs, pqPub, classicalPub)
}
func makeRecipientPrivs(pqPriv, classicalPriv crypto.RecipientPriv) []crypto.RecipientPriv {
privs := make([]crypto.RecipientPriv, 0, 2)
return append(privs, pqPriv, classicalPriv)
}
// ---------------------------------------------------------------------------
// Test KEM harness
//
@@ -286,7 +296,7 @@ func TestGoldenFormat(
out := &bytes.Buffer{}
if err := dec.Decrypt(
bytes.NewReader(goldenBytes),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
); err != nil {
t.Fatalf("Decrypt(golden) failed: %v", err)
@@ -304,8 +314,8 @@ func TestRoundTrip(
for _, size := range sizes {
t.Run(fmt.Sprintf("size=%d", size), func(t *testing.T) {
plaintext := make([]byte, size)
for i := 0; i < size; i++ {
plaintext[i] = byte(i)
for index := 0; index < size; index++ {
plaintext[index] = byte(index)
}
reg := fakeRegistry(t)
@@ -318,7 +328,7 @@ func TestRoundTrip(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader(plaintext),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -328,7 +338,7 @@ func TestRoundTrip(
out := &bytes.Buffer{}
if err := dec.Decrypt(
bytes.NewReader(encrypted.Bytes()),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
); err != nil {
t.Fatalf("Decrypt: %v", err)
@@ -354,7 +364,7 @@ func TestEmptyPlaintextSingleFinalChunk(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader(nil),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -394,7 +404,7 @@ func TestExactly64KiBTwoChunks(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader(plaintext),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -486,7 +496,7 @@ func TestTamperPayload(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader(plaintext),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -504,7 +514,7 @@ func TestTamperPayload(
out := &bytes.Buffer{}
err := dec.Decrypt(
bytes.NewReader(buf),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
)
if !errors.Is(err, ErrTamperingDetected) {
@@ -526,7 +536,7 @@ func TestTamperWrappedCEK(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader([]byte{0xAA}),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -545,7 +555,7 @@ func TestTamperWrappedCEK(
out := &bytes.Buffer{}
err := dec.Decrypt(
bytes.NewReader(buf),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
)
if !errors.Is(err, ErrTamperingDetected) {
@@ -575,7 +585,7 @@ func TestWrongPrivKey(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader([]byte{0x11, 0x22, 0x33}),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -605,7 +615,7 @@ func TestFormatConformance(
var out bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader([]byte{0x42}),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&out,
rand.Reader,
); err != nil {
@@ -649,7 +659,7 @@ func TestUnsupportedVersionNoGCM(
out := &bytes.Buffer{}
err := dec.Decrypt(
reader,
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
)
if !errors.Is(err, ErrUnsupportedVersion) {
@@ -723,7 +733,7 @@ func TestMalformedHeaderCtLenOverflow(
_, classicalPriv := generateFakeKeyPair(t, fakeRegistry(t), fakeClassicalSchemeID, rand.Reader)
err := dec.Decrypt(
reader,
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
&bytes.Buffer{},
)
if !errors.Is(err, ErrMalformedHeader) {
@@ -754,7 +764,7 @@ func TestZeroLengthNonFinalChunk(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader([]byte{0xAA}),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -770,7 +780,7 @@ func TestZeroLengthNonFinalChunk(
out := &bytes.Buffer{}
err := dec.Decrypt(
bytes.NewReader(corrupt.Bytes()),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
)
if !errors.Is(err, ErrMalformedChunk) {
@@ -792,7 +802,7 @@ func TestOversizedChunk(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader([]byte{0xAA}),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -808,7 +818,7 @@ func TestOversizedChunk(
out := &bytes.Buffer{}
err := dec.Decrypt(
bytes.NewReader(corrupt.Bytes()),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
)
if !errors.Is(err, ErrMalformedChunk) {
@@ -833,7 +843,7 @@ func TestPrematureEOF(
var encrypted bytes.Buffer
if err := enc.Encrypt(
bytes.NewReader(plaintext),
[]crypto.RecipientPub{pqPub, classicalPub},
makeRecipientPubs(pqPub, classicalPub),
&encrypted,
rand.Reader,
); err != nil {
@@ -853,7 +863,7 @@ func TestPrematureEOF(
out := &bytes.Buffer{}
err := dec.Decrypt(
bytes.NewReader(encrypted.Bytes()[:truncatedLen]),
[]crypto.RecipientPriv{pqPriv, classicalPriv},
makeRecipientPrivs(pqPriv, classicalPriv),
out,
)
if !errors.Is(err, ErrUnexpectedEOF) {